WeBid Bug Tracking

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000300WeBidAuctionspublic2011-07-10 14:052011-07-11 10:44
Reportersitemasters 
Assigned To 
Priority@0@SeverityminorReproducibilityhave not tried
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version1.0.2 
Target VersionFixed in Version1.0.4 
Summary0000300: Auction setup fee not working correctly, missing the equal to in the code
DescriptionThere is a bit of code that has been overlooked regarding the auction setup fee, namely the equal to sign.



For example if you have a fee table such as:



0.00 to 0.99 = 0.00

1.00 to 9.99 = 0.10

10.00 to 999.99 = 0.25



and so on...



If someone starts an auction for exactly 1.00 or 9.99 they are not charged any fee whatsoever.



Likewise if they start an auction for exactly 10.00 or 999.99 again they are not charged a single penny.



Clearly I would assume that less than (<) and greater than (>) has been used in the code without the equal to command i.e. equal to or less than (<=) and (=>) etc.



If someone can suggest where the equal to command needs to be inserted it would help a lot of people.
TagsNo tags attached.
import_id302
Thread
Attached Files

- Relationships

-  Notes
(0000768)
renlok (administrator)
2011-07-10 22:14
edited on: 2011-07-10 22:15

oh yeah good find in functions_sell.inc.php replace
[php]if ($minimum_bid > $row['fee_from'] && $minimum_bid < $row['fee_to'] && $row['type'] == 'setup')[/php]
with
[php]if ($minimum_bid >= $row['fee_from'] && $minimum_bid <= $row['fee_to'] && $row['type'] == 'setup')[/php]
(0000770)
sitemasters (reporter)
2011-07-11 10:44
edited on: 1970-01-01 00:00

Hi Renlok,

Thanks for that, although I maybe wrong but don't we need to make the following change in sell.tpl as well:

[PHP]if (setup[i][0] < min_bid && setup[i][1] > min_bid) {[/PHP]

[PHP]if (setup[i][0] <= min_bid && setup[i][1] >= min_bid) {[/PHP]

- Issue History
Date Modified Username Field Change
2015-04-01 13:17 renlok New Issue
2015-04-01 13:17 renlok import_id => 302
2015-04-01 13:17 renlok Date Submitted 2015-04-01 13:17 => 2011-07-10 14:05
2015-04-01 13:17 renlok Last Update 2015-04-01 13:17 => 2011-07-11 10:44


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker